Validate constant expressions for elem offset initialization #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #397 +/- ##
=======================================
Coverage 99.16% 99.16%
=======================================
Files 43 43
Lines 13027 13045 +18
=======================================
+ Hits 12918 12936 +18
Misses 109 109 |
axic
reviewed
Jun 26, 2020
| Global{{ValType::i32, true}, {ConstantExpression::Kind::Constant, {42}}}); | ||
| // Table contents: 0, 0xaa, 0xff, 0, ... | ||
| module.elementsec.emplace_back( | ||
| Element{{ConstantExpression::Kind::GlobalGet, {0}}, {0xaa, 0xff}}); |
There was a problem hiding this comment.
Oh, these contents were quite off :)
axic
approved these changes
Jun 26, 2020
|
@gumb0 it seems these aren't covered by the spectests? If so, can you leave a note in our list? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third part of #372