Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate block result types #407

Merged
merged 4 commits into from
Jul 20, 2020
Merged

Validate block result types #407

merged 4 commits into from
Jul 20, 2020

Conversation

gumb0
Copy link
Collaborator

@gumb0 gumb0 commented Jul 6, 2020 •
edited
Loading

Depends on #403

@codecov
Copy link

codecov bot commented Jul 6, 2020 •
edited
Loading

Codecov Report

Merging #407 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           master     #407    +/-   ##
========================================
  Coverage   99.18%   99.19%            
========================================
  Files          50       50            
  Lines       13818    13938   +120     
========================================
+ Hits        13706    13826   +120     
  Misses        112      112

@gumb0 gumb0 force-pushed the validate-types-block branch 6 times, most recently from d065e7c to a6bbc05 Compare July 8, 2020 10:05
@gumb0 gumb0 changed the base branch from master to validate-types-no-block-br July 8, 2020 12:55
@gumb0 gumb0 force-pushed the validate-types-no-block-br branch 4 times, most recently from fc1aa13 to c3183f5 Compare July 9, 2020 15:12
@chfast chfast force-pushed the validate-types-no-block-br branch from c3183f5 to d039bd4 Compare July 9, 2020 16:08
@gumb0 gumb0 force-pushed the validate-types-no-block-br branch from d039bd4 to 3ae6b8e Compare July 10, 2020 11:00
@gumb0 gumb0 mentioned this pull request Jul 13, 2020
Merged
@axic axic force-pushed the validate-types-no-block-br branch 3 times, most recently from 7d2c6c3 to 3adfb02 Compare July 16, 2020 16:02
@gumb0 gumb0 force-pushed the validate-types-no-block-br branch 2 times, most recently from 0d30b02 to 7beb186 Compare July 17, 2020 10:06
Base automatically changed from validate-types-no-block-br to master July 17, 2020 10:13
@gumb0 gumb0 marked this pull request as ready for review July 17, 2020 10:14
@gumb0
Copy link
Collaborator Author

gumb0 commented Jul 17, 2020

There's an option to simplify update_result_stack reusing drop_operand, but the error messages won't be specific to blocks. Pushed it as a last commit, what do you think?

@gumb0 gumb0 requested review from chfast and axic July 17, 2020 11:23
@gumb0
Copy link
Collaborator Author

gumb0 commented Jul 17, 2020

Rebased.

@axic axic merged commit 0a83cab into master Jul 20, 2020
@axic axic deleted the validate-types-block branch July 20, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chfast chfast chfast approved these changes

@axic axic axic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gumb0 @axic @chfast