-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spectests code coverage #410
Conversation
Codecov Report
@@ Coverage Diff @@
## master #410 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 49 49
Lines 13236 13237 +1
=======================================
+ Hits 13127 13128 +1
Misses 109 109 |
7eef1b1
to
e4eaf73
Compare
First spectests coverage report: https://21739-224892340-gh.circle-artifacts.com/0/coverage/index.html |
Do you mean splitting into collecting coverage and uploading to codecov.io? If so, maybe it's better to keep |
I can keep it but in case of upload failure spectests will not run at all. By codecov report I mean you can do two uploads - for unittests and spectests with different flags. Then you can filter by flags and have different stats. https://docs.codecov.io/docs/flags |
1ba1da8
to
1935d10
Compare
This might be a fine plan, but maybe we don't need to collect/upload spectest coverage for each PR? Maybe it could be manually triggered like benchmarks. |
It is better to keep it simple and collect every time. |
1935d10
to
1eafa54
Compare
This creates coverage report (same as for unittests) out of spectests execution. It is available as CircleCI artifact.
The codecov report can be split into two parts, but I'm leaving that for other time.
Closes #406