Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectests code coverage #410

Merged
merged 4 commits into from
Jul 15, 2020
Merged

Spectests code coverage #410

merged 4 commits into from
Jul 15, 2020

Conversation

chfast
Copy link
Collaborator

@chfast chfast commented Jul 7, 2020

This creates coverage report (same as for unittests) out of spectests execution. It is available as CircleCI artifact.

The codecov report can be split into two parts, but I'm leaving that for other time.

Closes #406

@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #410 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #410   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files          49       49           
  Lines       13236    13237    +1     
=======================================
+ Hits        13127    13128    +1     
  Misses        109      109           

@chfast chfast marked this pull request as ready for review July 7, 2020 10:29
@chfast
Copy link
Collaborator Author

chfast commented Jul 7, 2020

First spectests coverage report: https://21739-224892340-gh.circle-artifacts.com/0/coverage/index.html

@chfast chfast requested review from axic and gumb0 July 7, 2020 11:10
circle.yml Show resolved Hide resolved
@gumb0
Copy link
Collaborator

gumb0 commented Jul 7, 2020

The codecov report can be split into two parts, but I'm leaving that for other time.

Do you mean splitting into collecting coverage and uploading to codecov.io? If so, maybe it's better to keep --required till then, otherwise if it fails to upload, it will not be visible that previousle uploaded report was not updated?

@chfast
Copy link
Collaborator Author

chfast commented Jul 7, 2020

Do you mean splitting into collecting coverage and uploading to codecov.io? If so, maybe it's better to keep --required till then, otherwise if it fails to upload, it will not be visible that previousle uploaded report was not updated?

I can keep it but in case of upload failure spectests will not run at all.

By codecov report I mean you can do two uploads - for unittests and spectests with different flags. Then you can filter by flags and have different stats. https://docs.codecov.io/docs/flags

@gumb0
Copy link
Collaborator

gumb0 commented Jul 7, 2020

By codecov report I mean you can do two uploads - for unittests and spectests with different flags. Then you can filter by flags and have different stats. https://docs.codecov.io/docs/flags

This might be a fine plan, but maybe we don't need to collect/upload spectest coverage for each PR? Maybe it could be manually triggered like benchmarks.

@chfast
Copy link
Collaborator Author

chfast commented Jul 7, 2020

This might be a fine plan, but maybe we don't need to collect/upload spectest coverage for each PR? Maybe it could be manually triggered like benchmarks.

It is better to keep it simple and collect every time.

@chfast chfast merged commit 024a2fc into master Jul 15, 2020
@chfast chfast deleted the spectests_coverage branch July 15, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Get spectests coverage report
3 participants