Implement floating point const and add #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
value_type_cleanup
branch
from
246fdf8
to
dc41d64
Compare
gumb0
reviewed
Jul 16, 2020
|
Yes, makes sense.
…On Thu, Jul 16, 2020, 15:44 Andrei Maiboroda ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In lib/fizzy/value.hpp
<#424 (comment)>:
> + float f32;
+
+ Value() = default;
+
+ constexpr Value(uint64_t v) noexcept : i64{v} {}
+ constexpr Value(uint32_t v) noexcept : i64{v} {}
+ constexpr Value(int64_t v) noexcept : i64{static_cast<uint64_t>(v)} {}
+ constexpr Value(int32_t v) noexcept : i64{static_cast<uint32_t>(v)} {}
+
+ constexpr Value(float v) noexcept : f32{v} {}
+
+ constexpr operator uint64_t() const noexcept { return i64; }
+
+ /// Get the value as the given type. Handy in templates.
+ template <typename T>
+ constexpr T as() const noexcept
Can this be left without default implementation and then have
specializations for uint32_t and uint64_t similar to float?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#424 (review)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEL7RGC67KW3EBQS7XBGMLR33725ANCNFSM4O2WT76A>
.
|
Codecov Report
@@ Coverage Diff @@
## master #424 +/- ##
==========================================
- Coverage 99.54% 99.51% -0.03%
==========================================
Files 51 52 +1
Lines 14663 14791 +128
==========================================
+ Hits 14596 14719 +123
- Misses 67 72 +5 |
chfast
force-pushed
the
value_type_cleanup
branch
3 times, most recently
from
21a8bbe
to
d90f329
Compare
|
Doesnt this need spectest expectation update in CI? |
axic
approved these changes
Jul 30, 2020
I was expecting that, but no. What is the conditions for skipping a spec test? |
chfast
force-pushed
the
value_type_cleanup
branch
from
d90f329
to
accd4b2
Compare
chfast
force-pushed
the
value_f32
branch
3 times, most recently
from
e0b6b1c
to
c4b6629
Compare
axic
reviewed
Jul 30, 2020
| TEST(value, constructor_from_floating_points) | ||
| { | ||
| EXPECT_EQ(Value{123.456f}.f32, 123.456f); | ||
| EXPECT_EQ(Value{123.456789001}.f64, 123.456789001); |
There was a problem hiding this comment.
Would be nice to have a test for min/max, with a large mantissa.
There was a problem hiding this comment.
You mean the total max/min, or the biggest mantissa only?
There was a problem hiding this comment.
I used some special values in tests.
There was a problem hiding this comment.
Basically something which can not be represented in f32. f64::max() is fine, but not sure what that is actually storing, I believe a large exponent?
axic
approved these changes
Jul 30, 2020
axic
approved these changes
Jul 31, 2020
gumb0
reviewed
Jul 31, 2020
gumb0
reviewed
Jul 31, 2020
gumb0
reviewed
Jul 31, 2020
gumb0
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A symbolic milestone starting floating point support implementation.