Simplify trap handling #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #425 +/- ##
==========================================
- Coverage 98.73% 98.72% -0.01%
==========================================
Files 56 56
Lines 8704 8660 -44
==========================================
- Hits 8594 8550 -44
Misses 110 110 |
|
Well then let's do #219. It is a bit worrying how brittle the execution loop is to changes. |
chfast
approved these changes
Jul 16, 2020
gumb0
approved these changes
Jul 16, 2020
|
What are the number after #219 was merged? |
|
I re-benchmarked master. v1v1 to v2v1 to v3I would go with original version 1. |
|
@chfast are you interested remeasuring this? |
chfast
force-pushed
the
trap-handling
branch
from
2adf7a4
to
9fa4d26
Compare
|
For the GCC10, LTO: commit 1: commit last (marks trap as unlikely) So I think just using the first commit is good enough. Using |
chfast
force-pushed
the
trap-handling
branch
from
9fa4d26
to
1c878d0
Compare
chfast
approved these changes
Sep 9, 2020
axic
commented
Sep 9, 2020
chfast
force-pushed
the
trap-handling
branch
from
1c878d0
to
7d37bd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out of #219.