Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename execution_result -> ExecutionResult #428

Merged
merged 1 commit into from
Jul 17, 2020
Merged

Conversation

chfast
Copy link
Collaborator

@chfast chfast commented Jul 16, 2020

No description provided.

@chfast chfast requested review from axic and gumb0 July 16, 2020 18:17
@axic
Copy link
Member

axic commented Jul 16, 2020

Nice, I was about to ask why not rename it.

@chfast
Copy link
Collaborator Author

chfast commented Jul 16, 2020

Move it to separate header? I will use it also in WasmEngine.

@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #428 into master will not change coverage.
The diff coverage is 95.45%.

@@           Coverage Diff           @@
##           master     #428   +/-   ##
=======================================
  Coverage   99.35%   99.35%           
=======================================
  Files          49       49           
  Lines       13242    13242           
=======================================
  Hits        13156    13156           
  Misses         86       86           

@axic
Copy link
Member

axic commented Jul 16, 2020

Move it to separate header? I will use it also in WasmEngine.

I think that is a bad idea -- we would be trying to apply Fizzy's API to other engines. Why can't we leave WasmEngine as is, already uses optional?

Probably I could / will change my mind if we would expose host functions in WasmEngine.

@chfast
Copy link
Collaborator Author

chfast commented Jul 17, 2020

I think that is a bad idea -- we would be trying to apply Fizzy's API to other engines. Why can't we leave WasmEngine as is, already uses optional?

Sounds good.

@chfast chfast merged commit 987ee65 into master Jul 17, 2020
@chfast chfast deleted the rename_execution_result branch July 17, 2020 06:46
@gumb0 gumb0 restored the rename_execution_result branch July 22, 2020 13:56
@gumb0 gumb0 deleted the rename_execution_result branch July 22, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants