Add broken test cases for spectests #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
force-pushed
the
spectest-smoketests
branch
from
5045abf
to
b8c69ca
Compare
axic
commented
Jul 21, 2020
axic
commented
Jul 21, 2020
| total.failed += res.failed; | ||
| total.skipped += res.skipped; | ||
| } | ||
| catch (const std::exception& ex) |
There was a problem hiding this comment.
main has the very same catch all.
There was a problem hiding this comment.
Without it, it won't outuput TOTAL summary string in case of unexpected exception, but perhaps it's not important.
There was a problem hiding this comment.
I think if there's an exception we shouldn't try to recover, apart from displaying the exception.
axic
force-pushed
the
spectest-smoketests
branch
from
b8c69ca
to
421637e
Compare
gumb0
approved these changes
Jul 21, 2020
axic
force-pushed
the
spectest-smoketests
branch
from
421637e
to
08843e0
Compare
gumb0
approved these changes
Jul 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
==========================================
+ Coverage 99.19% 99.31% +0.12%
==========================================
Files 50 50
Lines 13938 13929 -9
==========================================
+ Hits 13826 13834 +8
+ Misses 112 95 -17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.