Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check floats compliance with IEEE 754 #462

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Check floats compliance with IEEE 754 #462

merged 1 commit into from
Aug 7, 2020

Conversation

chfast
Copy link
Collaborator

@chfast chfast commented Aug 7, 2020

This checks if the floating point types used to implement f32 and f64 Wasm types are compliant with IEEE 754.

The CMake check is rather difficult to do. We would need to check if a test program compiles.

@axic
Copy link
Member

axic commented Aug 7, 2020

Well at least with this they'll get a compile time error.

@chfast
Copy link
Collaborator Author

chfast commented Aug 7, 2020

Well at least with this they'll get a compile time error.

How is this different from CMake error?

@axic
Copy link
Member

axic commented Aug 7, 2020

Well at least with this they'll get a compile time error.

How is this different from CMake error?

By "cmake error" I meant which presents itself during configuration, e.g. cmake .., while this will present itself during build cmake --build. I'm fine with either if the configuration part is too complex.

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #462 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #462   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files          52       52           
  Lines       14937    14937           
=======================================
  Hits        14863    14863           
  Misses         74       74           

@axic axic merged commit ab2b2fe into master Aug 7, 2020
@axic axic deleted the check_ieee_754 branch August 7, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants