Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Convert WAST test to JSON #465

Merged
merged 3 commits into from
Sep 9, 2020
Merged

CI: Convert WAST test to JSON #465

merged 3 commits into from
Sep 9, 2020

Conversation

chfast
Copy link
Collaborator

@chfast chfast commented Aug 7, 2020

Adds simple script to convert WAST tests to JSON on CI instead of
relaying on JSON files being available in the wasm-spec repo.

@chfast chfast force-pushed the ci_spectests branch 2 times, most recently from 5bc8b5a to 06d5d04 Compare August 17, 2020 09:19
circle.yml Outdated Show resolved Hide resolved
circle.yml Outdated Show resolved Hide resolved
@chfast chfast force-pushed the ci_spectests branch 2 times, most recently from f3f84fb to 7cdf7e4 Compare August 25, 2020 10:49
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #465 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #465   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files          56       56           
  Lines        8704     8704           
=======================================
  Hits         8594     8594           
  Misses        110      110           

circle.yml Outdated Show resolved Hide resolved
circle.yml Outdated Show resolved Hide resolved
@chfast chfast force-pushed the ci_spectests branch 2 times, most recently from 010ba71 to e3ee791 Compare September 2, 2020 08:40
@chfast chfast changed the title CI: Convert wast test to json CI: Convert WAST test to JSON Sep 2, 2020
@chfast chfast marked this pull request as ready for review September 2, 2020 08:41
@chfast chfast requested review from axic and gumb0 September 2, 2020 08:42
circle.yml Show resolved Hide resolved
@gumb0
Copy link
Collaborator

gumb0 commented Sep 3, 2020

With WABT 1.0.19 we have to run wat2wasm in wat2wasm4cpp.py (and probably wast2json probably, too) disabling extensions they have on by default now. Flags needed: --disable-saturating-float-to-int, --disable-sign-extension, --disable-multi-value.

@chfast
Copy link
Collaborator Author

chfast commented Sep 3, 2020

With WABT 1.0.19 we have to run wat2wasm in wat2wasm4cpp.py (and probably wast2json probably, too) disabling extensions they have on by default now. Flags needed: --disable-saturating-float-to-int, --disable-sign-extension, --disable-multi-value.

Correct. We probably should disable every extension explicitly (except mutable globals).

circle.yml Outdated Show resolved Hide resolved
test/spectests/README.md Outdated Show resolved Hide resolved
test/spectests/README.md Outdated Show resolved Hide resolved
test/spectests/README.md Outdated Show resolved Hide resolved
test/spectests/README.md Outdated Show resolved Hide resolved
test/spectests/README.md Outdated Show resolved Hide resolved
@chfast chfast force-pushed the ci_spectests branch 2 times, most recently from c70fea5 to f3676eb Compare September 9, 2020 19:44
Adds simple script to convert WAST tests to JSON on CI instead of
relaying on JSON files being available in the wasm-spec repo.
@chfast chfast merged commit 1a08187 into master Sep 9, 2020
@chfast chfast deleted the ci_spectests branch September 9, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants