Implement {f32,f64}.sqrt instructions #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gumb0
commented
Aug 13, 2020
•
gumb0
commented
gumb0
changed the title
gumb0
changed the title
Codecov Report
@@ Coverage Diff @@
## master #480 +/- ##
=======================================
Coverage 99.54% 99.54%
=======================================
Files 54 54
Lines 16265 16324 +59
=======================================
+ Hits 16191 16250 +59
Misses 74 74 |
chfast
approved these changes
Aug 13, 2020
|
|
||
| EXPECT_THAT(exec(TypeParam{1}), Result(TypeParam{1})); | ||
| EXPECT_THAT(exec(TypeParam{4}), Result(TypeParam{2})); | ||
| EXPECT_THAT(exec(TypeParam{0x1.21p+6}), Result(TypeParam{0x1.1p3})); |
There was a problem hiding this comment.
Suggested change
| EXPECT_THAT(exec(TypeParam{0x1.21p+6}), Result(TypeParam{0x1.1p3})); | |
| EXPECT_THAT(exec(TypeParam{0x1.21p6}), Result(TypeParam{0x1.1p3})); |
axic
reviewed
Aug 13, 2020
| @@ -223,6 +223,36 @@ TYPED_TEST(execute_floating_point_types, nan_matchers) | |||
| EXPECT_THAT(ExecutionResult{Value{-FP::nan(1)}}, Not(ArithmeticNaN(TypeParam{}))); | |||
| } | |||
|
|
|||
| TYPED_TEST(execute_floating_point_types, unop_nan_propagation) | |||
| { | |||
| // Tests NaN propagation in unary instructions (unnop). | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.