Extend tests with all rounding directions #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #500 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 54 54
Lines 17108 17180 +72
=======================================
+ Hits 17053 17125 +72
Misses 55 55 |
chfast
force-pushed
the
rounding_direction_tests
branch
2 times, most recently
from
afe00a9
to
6897640
Compare
axic
reviewed
Aug 21, 2020
| @@ -355,42 +364,43 @@ TYPED_TEST(execute_floating_point_types, binop_nan_propagation) | |||
| for (const auto op : opcodes) | |||
| { | |||
| auto instance = instantiate(parse(this->get_binop_code(op))); | |||
| const auto exec = [&](auto arg1, auto arg2) { return execute(*instance, 0, {arg1, arg2}); }; | |||
There was a problem hiding this comment.
Any particular need for this refactoring or just making it less code duplication?
axic
reviewed
Aug 21, 2020
| { | ||
| EXPECT_THAT(execute(*inst, eq, {a, b}), Result(0)) << a << "==" << b; |
There was a problem hiding this comment.
Strange why did clang-format agree with previous identation.
axic
approved these changes
Aug 21, 2020
|
@gumb0 hint: if you want to review this post-merge, make sure to turn on "hide whitespace changes" in the diff. |
chfast
force-pushed
the
rounding_direction_tests
branch
from
6897640
to
a767eb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.