Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spectests with backports #534

Merged
merged 2 commits into from
Nov 17, 2020
Merged

Update spectests with backports #534

merged 2 commits into from
Nov 17, 2020

Conversation

gumb0
Copy link
Collaborator

@gumb0 gumb0 commented Sep 18, 2020

At this stage, it has 5 spectests failures.

TODO:

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #534 (25feb8d) into master (b58d6e6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #534   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files          69       69           
  Lines        9622     9622           
=======================================
  Hits         9465     9465           
  Misses        157      157           

@chfast chfast force-pushed the update-spectests branch 3 times, most recently from 2431980 to 7b4cf27 Compare November 10, 2020 17:48
@chfast chfast marked this pull request as ready for review November 10, 2020 19:39
@chfast chfast force-pushed the update-spectests branch 2 times, most recently from 0c53e5b to 88e8d79 Compare November 12, 2020 09:07
@gumb0
Copy link
Collaborator Author

gumb0 commented Nov 13, 2020

Approved.

I double-checked the commits in the branch, they look fine.
The commits in wasm master that are skipped in the branch are all adding post-1.0 features:
WebAssembly/spec@55a5e2c
WebAssembly/spec@484180b
WebAssembly/spec@e308ca2
WebAssembly/spec@c8fd933

The new 22 skipped tests are all testing text representation:

Running tests from /home/andrei/dev/wasm-spec/test/core/json/func.json
........................................................................s.........ssssssssss..............................ssssssssssss
Line 315: assert_malformed SKIPPED Only binary modules are supported.
Line 427: assert_malformed SKIPPED Only binary modules are supported.
Line 434: assert_malformed SKIPPED Only binary modules are supported.
Line 441: assert_malformed SKIPPED Only binary modules are supported.
Line 448: assert_malformed SKIPPED Only binary modules are supported.
...
Line 720: assert_malformed SKIPPED Only binary modules are supported.
Line 722: assert_malformed SKIPPED Only binary modules are supported.

Running tests from /home/andrei/dev/wasm-spec/test/core/json/global.json
..............................................................................sss
Line 486: assert_malformed SKIPPED Only binary modules are supported.
Line 490: assert_malformed SKIPPED Only binary modules are supported.
Line 494: assert_malformed SKIPPED Only binary modules are supported.

	Running tests from /home/andrei/dev/wasm-spec/test/core/json/memory.json
..............................sss...........................................sss
Line 80: assert_malformed SKIPPED Only binary modules are supported.
Line 84: assert_malformed SKIPPED Only binary modules are supported.
Line 88: assert_malformed SKIPPED Only binary modules are supported.
Line 231: assert_malformed SKIPPED Only binary modules are supported.
Line 235: assert_malformed SKIPPED Only binary modules are supported.
Line 239: assert_malformed SKIPPED Only binary modules are supported.
79 tests ran from memory.json.
  PASSED 73, FAILED 0, SKIPPED 6.

  	Running tests from /home/andrei/dev/wasm-spec/test/core/json/table.json
.............ssssss
Line 28: assert_malformed SKIPPED Only binary modules are supported.
Line 32: assert_malformed SKIPPED Only binary modules are supported.
Line 36: assert_malformed SKIPPED Only binary modules are supported.
Line 43: assert_malformed SKIPPED Only binary modules are supported.
Line 47: assert_malformed SKIPPED Only binary modules are supported.
Line 51: assert_malformed SKIPPED Only binary modules are supported.
19 tests ran from table.json.
  PASSED 13, FAILED 0, SKIPPED 6.

@axic axic changed the title Update spectests Update spectests with backports Nov 17, 2020
@axic axic merged commit 1e3d1a2 into master Nov 17, 2020
@axic axic deleted the update-spectests branch November 17, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants