-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use native C++20 feature for bit_cast if available #542
Conversation
This is not doable right now because only MSVC has implemented |
Well we could use this other macro:
But since we don't support compilation with MSVC it can't be tested. |
This still holds. |
Codecov Report
@@ Coverage Diff @@
## master #542 +/- ##
==========================================
- Coverage 99.12% 99.10% -0.02%
==========================================
Files 81 81
Lines 12985 12941 -44
==========================================
- Hits 12871 12825 -46
- Misses 114 116 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Totally skipped over this fact. |
This is waiting for GCC+11 now: https://www.gnu.org/software/gcc/gcc-11/changes.html |
GCC 11 and Clang 14 has this now. Since #804 at least gcc is of correct version. |
Tested with introduced a compilation error that the code is actually compiled on gcc 11. |
Fixes https://github.com/wasmx/fizzy/pull/535/files#r492656891.