Asserts for checking expected number of inputs/outputs

[chfast]

No description provided.

[chfast]

Use func_type, the stack.size() is only used in asserts.

[gumb0]

I didn't get, why is it better?

It looks you could do assertions like

assert(args.size() == instance.module.get_function_type(func_idx).inputs.size());

assert(stack.size() == instance.module.get_function_type(func_idx).inputs.outputs.size());

and then avoid another variable declaration in outer scope and get_function_type() call.

I kind of liked the fact that execute doesn't need to access called function type, because all type stuff is handled at validation...

[chfast]

You are right here.

It looks we don't need information about number of outputs. But we will probably need the information about number of arguments. In the end to bootstrap execution we need:

• number of arguments,
• number of locals,
• max stack height.

[codecov]

Codecov Report

Merging #547 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #547   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files          59       59           
  Lines        8932     8948   +16     
=======================================
+ Hits         8811     8827   +16     
  Misses        121      121