-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Fix spectest failure output #548
Conversation
d749bed
to
459dc11
Compare
Codecov Report
@@ Coverage Diff @@
## master #548 +/- ##
=======================================
Coverage 98.74% 98.74%
=======================================
Files 58 58
Lines 8765 8765
=======================================
Hits 8655 8655
Misses 110 110 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a regression test? In CTest you can check output.
And make sure the expected is non-zero so we can see the hex/dec there too. |
set_tests_properties( | ||
fizzy/smoketests/spectests/failures-output | ||
PROPERTIES | ||
PASS_REGULAR_EXPRESSION "FAILED Incorrect returned value\\. Expected: 2 \\(0x2\\) Actual: 10 \\(0xa\\)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PASS_REGULAR_EXPRESSION "FAILED Incorrect returned value\\. Expected: 2 \\(0x2\\) Actual: 10 \\(0xa\\)" | |
PASS_REGULAR_EXPRESSION "FAILED Incorrect returned value\\. Expected: 12 \\(0xc\\) Actual: 10 \\(0xa\\)" |
So that both expected and actual are >9.
86865e1
to
ca457a1
Compare
ca457a1
to
bbd9e34
Compare
Before:
After: