cmake: Add configuration for Cmake Package #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
cmake_package
branch
from
dea7242
to
972b035
Compare
Codecov Report
@@ Coverage Diff @@
## master #553 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 61 61
Lines 8959 8959
=======================================
Hits 8838 8838
Misses 121 121 |
gumb0
reviewed
Sep 25, 2020
chfast
force-pushed
the
cmake_fizzy_internal
branch
from
f4e8fe1
to
b007b09
Compare
chfast
force-pushed
the
cmake_package
branch
from
972b035
to
5fd3677
Compare
gumb0
approved these changes
Sep 25, 2020
axic
reviewed
Sep 30, 2020
| @@ -100,5 +104,12 @@ if(FIZZY_TESTING) | |||
| add_subdirectory(test) | |||
| endif() | |||
|
|
|||
| set(CMAKE_INSTALL_CMAKEPACKAGEDIR ${CMAKE_INSTALL_LIBDIR}/cmake/${PROJECT_NAME}) | |||
|
|
|||
| write_basic_package_version_file(fizzyConfigVersion.cmake COMPATIBILITY ExactVersion) | |||
axic
reviewed
Sep 30, 2020
| # This example shows how to use the fizzy library from the fizzy CMake package. | ||
| cmake_minimum_required(VERSION 3.15) | ||
| project(use_fizzy LANGUAGES CXX) | ||
| find_package(fizzy CONFIG REQUIRED) |
There was a problem hiding this comment.
So this use_fizzy directory is a test for find_package(fizzy)?
axic
approved these changes
Sep 30, 2020
chfast
commented
Sep 30, 2020
There was a problem hiding this comment.
CMake package consist of a number of special files.
fizzyConfig.cmake- the main one;find_package(fizzy CONFIG)is looking for it; it is generated fromConfig.cmake.inin https://github.com/wasmx/fizzy/pull/553/files#diff-af3b638bc2a3e6c650974192a53c7291R110.fizzyConfigVersion.cmake- it contains a script to resolved required version infind_package(fizzy VERSION a.b.c); generated by https://github.com/wasmx/fizzy/pull/553/files#diff-af3b638bc2a3e6c650974192a53c7291R109; we opt for "ExactVersion" compatibility.fizzyTargets.cmake- contains information about all "installed" targets; generate and installed byinstall(EXPORT ...)in https://github.com/wasmx/fizzy/pull/553/files#diff-af3b638bc2a3e6c650974192a53c7291R114.
CMake docs in subject: https://cmake.org/cmake/help/latest/manual/cmake-packages.7.html
In summary: there is a shit lot of boilerplate here and essential parts well hidden in-between.
chfast
force-pushed
the
cmake_package
branch
from
5fd3677
to
4274c04
Compare
chfast
force-pushed
the
cmake_package
branch
from
4274c04
to
9927571
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.