Fix invoke: drop args after the call #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
Oct 5, 2020
|
|
||
| const auto ret = func(instance, call_args, depth + 1); | ||
| // Bubble up traps | ||
| if (ret.trapped) | ||
| return false; | ||
|
|
||
| stack.drop(num_args); |
There was a problem hiding this comment.
If we want to be pedantic, shouldn't this happen before the trap?
There was a problem hiding this comment.
No. Trap terminates this execution, so we can keep stack unchanged.
|
Are tests possible for this? |
No, because |
|
How about the test to check that args remain on stack in case of trap, if want this to be intended behaviour? |
|
Stack is not accessible from outside. |
gumb0
approved these changes
Oct 5, 2020
axic
approved these changes
Oct 5, 2020
Codecov Report
@@ Coverage Diff @@
## master #573 +/- ##
=======================================
Coverage 98.24% 98.24%
=======================================
Files 62 62
Lines 9062 9062
=======================================
Hits 8903 8903
Misses 159 159 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes logical error in
invoke_function()implementation. The call arguments are now dropped from the stack after the call returns.Performance difference is not significant.