rust: properly package the C/C++ dependencies #585
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #584 mostly.
Now I feel dumb, but at least finally understood the reason: Cargo creates a tarball (with the
.crate
extension). It copies everything from the crate directory, including symlinks which it follows and includes fully.The reason it works in evmc is that it can follow the single header symlink. The reason it did not work with symlinking to
../../
because that would be recursive for tar. Fixed it with symlinking the appropriate files/directories. I think this is the best we can do without moving the crate int the root and making it worse (by for example having twosrc
directories or mixing Rust/C++ source code).