Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: properly package the C/C++ dependencies #585

Merged
merged 1 commit into from
Oct 6, 2020
Merged

rust: properly package the C/C++ dependencies #585

merged 1 commit into from
Oct 6, 2020

Conversation

axic
Copy link
Member

@axic axic commented Oct 6, 2020

This reverts #584 mostly.

Now I feel dumb, but at least finally understood the reason: Cargo creates a tarball (with the .crate extension). It copies everything from the crate directory, including symlinks which it follows and includes fully.

The reason it works in evmc is that it can follow the single header symlink. The reason it did not work with symlinking to ../../ because that would be recursive for tar. Fixed it with symlinking the appropriate files/directories. I think this is the best we can do without moving the crate int the root and making it worse (by for example having two src directories or mixing Rust/C++ source code).

@axic axic requested review from chfast and gumb0 October 6, 2020 15:10
@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #585 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #585   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files          62       62           
  Lines        8990     8990           
=======================================
  Hits         8831     8831           
  Misses        159      159           

@axic axic merged commit 543319d into master Oct 6, 2020
@axic axic deleted the rust-package branch October 6, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants