C API Instance memory access #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
force-pushed
the
capi-instance-memory2
branch
2 times, most recently
from
40f90df
to
7c8012f
Compare
Codecov Report
@@ Coverage Diff @@
## master #596 +/- ##
=======================================
Coverage 98.24% 98.25%
=======================================
Files 63 63
Lines 9180 9224 +44
=======================================
+ Hits 9019 9063 +44
Misses 161 161 |
axic
reviewed
Oct 12, 2020
| @@ -90,6 +90,14 @@ FizzyInstance* fizzy_instantiate(const FizzyModule* module, | |||
| /// Free resources associated with the instance. | |||
| void fizzy_free_instance(FizzyInstance* instance); | |||
|
|
|||
| /// Get pointer to memory of an instance. | |||
| /// @returns Pointer to memory data or NULL in case instance doesn't have any memory. | |||
There was a problem hiding this comment.
It gives access to any memory
There was a problem hiding this comment.
Can you clarify that in the description?
axic
reviewed
Oct 12, 2020
axic
reviewed
Oct 12, 2020
gumb0
force-pushed
the
capi-execute-dynamic-module
branch
from
f38f7e5
to
59419bd
Compare
gumb0
force-pushed
the
capi-instance-memory2
branch
from
7c8012f
to
287461e
Compare
axic
reviewed
Oct 12, 2020
test/unittests/capi_test.cpp
Outdated
| @@ -75,6 +75,71 @@ TEST(capi, free_instance_null) | |||
| fizzy_free_instance(nullptr); | |||
| } | |||
|
|
|||
| TEST(capi, memory_access) | |||
There was a problem hiding this comment.
I think this is the imported_memory_access and the other case is memory_access.
gumb0
force-pushed
the
capi-instance-memory2
branch
from
287461e
to
01cdc30
Compare
gumb0
force-pushed
the
capi-instance-memory2
branch
from
01cdc30
to
bbea2e4
Compare
axic
approved these changes
Oct 12, 2020
chfast
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.