Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix TestFloat compilation #605

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Conversation

chfast
Copy link
Collaborator

@chfast chfast commented Oct 14, 2020

No description provided.

@chfast chfast force-pushed the ci_testfloat_build branch 2 times, most recently from b7a5331 to 8433572 Compare October 14, 2020 11:48
@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #605 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #605   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files          63       63           
  Lines        9238     9238           
=======================================
  Hits         9078     9078           
  Misses        160      160           

circle.yml Outdated Show resolved Hide resolved
@chfast chfast marked this pull request as ready for review October 14, 2020 14:15
@@ -49,6 +49,9 @@ commands:
working_directory: /tmp
command: |
if [ ! -f testfloat_gen ]; then
# GCC compiler is expected, create link from clang if gcc not available.
type gcc || (cd $(dirname $(which clang)) && ln -s clang gcc)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what problem is this solving if the CI was not breaking? Some future PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This problem is not visible usually, because we take the binary from cache. But cache is disabled for external PRs (like this one) and then jobs having clang compiler only fails. The makefile from TestFloat is using gcc for compiler instead of cc.

@@ -49,6 +49,9 @@ commands:
working_directory: /tmp
command: |
if [ ! -f testfloat_gen ]; then
# GCC compiler is expected, create link from clang if gcc not available.
type gcc || (cd $(dirname $(which clang)) && ln -s clang gcc)

git clone --depth=1 --single-branch https://github.com/ucb-bar/berkeley-softfloat-3.git
git clone --depth=1 --single-branch https://github.com/ucb-bar/berkeley-testfloat-3.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While at it, can we use a specific tag/branch/version of these repos?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has no tags.

@chfast
Copy link
Collaborator Author

chfast commented Oct 14, 2020

@chfast chfast merged commit 3f44488 into wasmx:master Oct 14, 2020
@chfast chfast deleted the ci_testfloat_build branch October 14, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants