-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Fix TestFloat compilation #605
Conversation
b7a5331
to
8433572
Compare
Codecov Report
@@ Coverage Diff @@
## master #605 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 63 63
Lines 9238 9238
=======================================
Hits 9078 9078
Misses 160 160 |
8433572
to
600d43d
Compare
@@ -49,6 +49,9 @@ commands: | |||
working_directory: /tmp | |||
command: | | |||
if [ ! -f testfloat_gen ]; then | |||
# GCC compiler is expected, create link from clang if gcc not available. | |||
type gcc || (cd $(dirname $(which clang)) && ln -s clang gcc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what problem is this solving if the CI was not breaking? Some future PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This problem is not visible usually, because we take the binary from cache. But cache is disabled for external PRs (like this one) and then jobs having clang compiler only fails. The makefile from TestFloat is using gcc
for compiler instead of cc
.
@@ -49,6 +49,9 @@ commands: | |||
working_directory: /tmp | |||
command: | | |||
if [ ! -f testfloat_gen ]; then | |||
# GCC compiler is expected, create link from clang if gcc not available. | |||
type gcc || (cd $(dirname $(which clang)) && ln -s clang gcc) | |||
|
|||
git clone --depth=1 --single-branch https://github.com/ucb-bar/berkeley-softfloat-3.git | |||
git clone --depth=1 --single-branch https://github.com/ucb-bar/berkeley-testfloat-3.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While at it, can we use a specific tag/branch/version of these repos?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has no tags.
Here is the issue this is fixing: https://app.circleci.com/pipelines/github/wasmx/fizzy/5194/workflows/40c72657-fbc3-4bd7-8675-ef727b19e795/jobs/39374. |
600d43d
to
47ac67d
Compare
No description provided.