C API instantiate with resolving imported functions #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
Oct 15, 2020
include/fizzy/fizzy.h
Outdated
| /// | ||
| /// @note | ||
| /// Functions in @a imported_functions are allowed to be in any order and allowed to include some | ||
| /// functions not required by instantiated module. |
There was a problem hiding this comment.
Suggested change
| /// functions not required by instantiated module. | |
| /// functions not required by the module. |
axic
reviewed
Oct 15, 2020
test/unittests/capi_test.cpp
Outdated
| @@ -190,7 +283,8 @@ TEST(capi, memory_access) | |||
| ) | |||
| */ | |||
| const auto wasm = from_hex( | |||
| "0061736d010000000105016000017f0302010005030100010a0901070041002802000b0b08010041010b02112" | |||
| "0061736d010000000105016000017f0302010005030100010a0901070041002802000b0b08010041010b02" | |||
| "112" | |||
| "2"); | |||
There was a problem hiding this comment.
I don't know why it did, reverted.
gumb0
force-pushed
the
capi-resolve-instantiate
branch
from
34bcd69
to
5c6067d
Compare
gumb0
force-pushed
the
capi-resolve-instantiate
branch
from
5c6067d
to
fb87759
Compare
axic
approved these changes
Oct 15, 2020
Codecov Report
@@ Coverage Diff @@
## master #608 +/- ##
==========================================
- Coverage 98.26% 98.24% -0.02%
==========================================
Files 63 63
Lines 9294 9370 +76
==========================================
+ Hits 9133 9206 +73
- Misses 161 164 +3 |
chfast
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #565