Refactor table and simplify calls #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #616 +/- ##
==========================================
+ Coverage 98.33% 98.35% +0.01%
==========================================
Files 69 69
Lines 9535 9526 -9
==========================================
- Hits 9376 9369 -7
+ Misses 159 157 -2 |
gumb0
force-pushed
the
table-refactor
branch
2 times, most recently
from
45c070b
to
98a8d93
Compare
gumb0
commented
Oct 21, 2020
| // This pointer is empty most of the time and is used only to keep instance alive in one edge | ||
| // case, when start function traps, but instantiate has already modified some elements of a | ||
| // shared (imported) table. | ||
| std::shared_ptr<Instance> shared_instance; |
There was a problem hiding this comment.
This is a simple way to keep instance alive as long as there is function using it in some table. This was previously achieved by capturing this shared_ptr<Instance> in std::function of table element.
Now this looks like an overhead included in each table element every time, but needed only in weird edge case.
But on the other hand, previously there was std::function's dynamic allocation overhead for each table element all the time, and now this shared_ptr stays empty in normal cases, so this theoretically should be overall more efficient than before.
There was a problem hiding this comment.
This is better now. But I'd still prefer to handle that differently (not necessarily in this PR): either separate start() from instantiate() or return tuble Instance*, bool from instantiate().
|
Clang10 with LTO |
chfast
reviewed
Oct 21, 2020
| // This pointer is empty most of the time and is used only to keep instance alive in one edge | ||
| // case, when start function traps, but instantiate has already modified some elements of a | ||
| // shared (imported) table. | ||
| std::shared_ptr<Instance> shared_instance; |
There was a problem hiding this comment.
This is better now. But I'd still prefer to handle that differently (not necessarily in this PR): either separate start() from instantiate() or return tuble Instance*, bool from instantiate().
chfast
approved these changes
Oct 21, 2020
chfast
force-pushed
the
table-refactor
branch
from
b7c4c9a
to
4ab5a58
Compare
|
AMD EPYC 7601, GCC10, no LTO |
|
AMD EPYC 7601, GCC10, LTO |
chfast
force-pushed
the
table-refactor
branch
from
4ab5a58
to
74bda14
Compare
|
axic
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out of #615