capi: Add imported globals to instantiate #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
force-pushed
the
capi-imported-globals
branch
from
aea94af
to
9f85c86
Compare
Codecov Report
@@ Coverage Diff @@
## master #624 +/- ##
=======================================
Coverage 98.32% 98.32%
=======================================
Files 67 67
Lines 9429 9493 +64
=======================================
+ Hits 9271 9334 +63
- Misses 158 159 +1 |
gumb0
force-pushed
the
capi-imported-globals
branch
3 times, most recently
from
d86e365
to
496cbcf
Compare
gumb0
force-pushed
the
capi-imported-globals
branch
from
496cbcf
to
4a9d97e
Compare
gumb0
commented
Oct 27, 2020
| /// @returns non-NULL pointer to instance in case of success, NULL otherwise. | ||
| /// | ||
| /// @note | ||
| /// Functions in @a imported_functions are allowed to be in any order and allowed to include some | ||
| /// functions not required by the module. | ||
| /// Functions are matched to module's imports based on their module and name strings. | ||
| /// @note | ||
| /// Function expects @a imported_globals to be in the order of imports defined in the module. |
There was a problem hiding this comment.
It's weird how fizzy_resolve_instantiate currently doesn't resolve globals the way it resolves functions. C++ backend doesn't allow this currently, and I don't know how important it is.
There was a problem hiding this comment.
I agree there should be a function similar to functions to resolve globals in the C++ API. That could be used here.
Probably at that point I'd rename the to instantiates as fizzy_instantiate (which does resolution) and fizzy_unsafe_instantiate (which doesn't).
axic
reviewed
Oct 27, 2020
| @@ -20,12 +20,12 @@ typedef struct FizzyInstance FizzyInstance; | |||
| /// The data type representing numeric values. | |||
| /// | |||
| /// i64 member is used to represent values of both i32 and i64 type. | |||
| union FizzyValue | |||
| typedef union FizzyValue | |||
There was a problem hiding this comment.
Hmm, wonder how the Rust binding will act with this, will check.
axic
approved these changes
Oct 27, 2020
chfast
approved these changes
Oct 27, 2020
gumb0
force-pushed
the
capi-imported-globals
branch
from
4a9d97e
to
d637e86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.