test: Refactor utils for binop/unop tests

[chfast]

No description provided.

[axic]

I think some of these changes are in conflict with (or duplicated in) #655, lets wait for that.

[codecov]

Codecov Report

Merging #651 (ff747ef) into master (9a25602) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #651   +/-   ##
=======================================
  Coverage   99.30%   99.30%           
=======================================
  Files          72       72           
  Lines       10067    10090   +23     
=======================================
+ Hits         9997    10020   +23     
  Misses         70       70           

Flag	Coverage Δ
spectests	91.50% <ø> (ø)
unittests	99.30% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
test/unittests/execute_numeric_test.cpp	100.00% <100.00%> (ø)

[axic]

Will these create helpers used later in other PRs?

[chfast]

The i64_eqz is using it.

[axic]

The point is to avoid type check or why is it needed?

[chfast]

It is not needed, but it is lame to create module+instance for every test case. Here we create a lambda capturing the instance and we can execute multiple test cases.

[axic]

Well, the fresh instance gives the benefit, that nothing is dirty anywhere in the instance. However this way perhaps we could catch other bugs/problems caused by some uncleaned state.

[gumb0]

It is not needed, but it is lame to create module+instance for every test case. Here we create a lambda capturing the instance and we can execute multiple test cases.

But there are many tests still using execute_unary_operation / execute_binary_operation, why leave it inconsistent?

[chfast]

This PR mostly enables you to do the change. I needed it for more eqz test cases. For other instructions I prefer to go one-by-one later and add more test cases (something more than 42). But I can syntactically replace the code right now if you prefer all at once (will not add more cases though).

[gumb0]

I would prefer to replace all of them here, if it's easy. (and remove execute_* functions)

[gumb0]

Should this check go inside lambda now?

[chfast]

The test::execute() checks types inside.

[chfast]

1. I moved i64_eqz enhancement to test: Enhance the i64_eqz tests #679.
2. Here we have one old commit which reworks the helpers + 2 commits updating the syntax of test cases. There can be squashed in various combinations if any preferences.
3. The last WIP commit merges tests of the same instruction. I think it is fine doing it this way, but I don't have to proceed.