test: improve capi.imported_memory_access test #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #665 +/- ##
=======================================
Coverage 99.29% 99.29%
=======================================
Files 71 71
Lines 9805 9821 +16
=======================================
+ Hits 9736 9752 +16
Misses 69 69
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chfast
reviewed
Nov 25, 2020
| memory_data[0] = 0xaa; | ||
| memory_data[1] = 0xbb; | ||
|
|
||
| EXPECT_EQ(fizzy_execute(instance, 0, nullptr, 0).value.i64, 0x22bbaa); |
There was a problem hiding this comment.
Also check memory in instance_memory.
test/unittests/capi_test.cpp
Outdated
| from_hex("0061736d010000000503010001070701036d656d02000b08010041010b021122"); | ||
| auto module_memory = fizzy_parse(wasm_memory.data(), wasm_memory.size()); | ||
| ASSERT_NE(module_memory, nullptr); | ||
| auto instance_memory = |
There was a problem hiding this comment.
For readability, you can indicate which objects are pointers by auto*.
gumb0
force-pushed
the
capi-imported-memory-access
branch
from
32e8a89
to
91a31c5
Compare
chfast
approved these changes
Nov 25, 2020
gumb0
force-pushed
the
capi-imported-memory-access
branch
from
91a31c5
to
2e6c1e9
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was added before imporing memory was supported in C API. Now I remembered that it should actually test something.