Correct max call depth #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
force-pushed
the
correct_max_call_depth
branch
2 times, most recently
from
9df36dc
to
bec86e9
Compare
Codecov Report
@@ Coverage Diff @@
## master #669 +/- ##
=======================================
Coverage 99.27% 99.27%
=======================================
Files 71 71
Lines 9855 9855
=======================================
Hits 9784 9784
Misses 71 71
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gumb0
approved these changes
Dec 3, 2020
There was a problem hiding this comment.
Looks fine, but consider merging two tests here or in #666
#666 (comment)
chfast
force-pushed
the
correct_max_call_depth
branch
from
bec86e9
to
beb59bf
Compare
gumb0
approved these changes
Dec 4, 2020
chfast
force-pushed
the
correct_max_call_depth
branch
from
beb59bf
to
c370263
Compare
chfast
force-pushed
the
correct_max_call_depth
branch
from
c370263
to
1a3a053
Compare
axic
reviewed
Dec 28, 2020
Previously there were 2049 number of recursive calls allowed (depth levels from 0 to 2048). With this change the number is reduced to 2048 (depth levels from 0 to 2047).
chfast
force-pushed
the
correct_max_call_depth
branch
from
1a3a053
to
4e411f0
Compare
axic
approved these changes
Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there were 2049 number of recursive calls allowed (depth levels from 0 to 2048). With this change the number is reduced to 2048 (depth levels from 0 to 2047).