test: Log error message for spectests expecting a failure #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
force-pushed
the
spectest-pass-error
branch
from
b5b4d39
to
3dd9269
Compare
Codecov Report
@@ Coverage Diff @@
## master #672 +/- ##
=======================================
Coverage 99.29% 99.29%
=======================================
Files 71 71
Lines 9805 9805
=======================================
Hits 9736 9736
Misses 69 69
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chfast
reviewed
Dec 11, 2020
| @@ -293,15 +293,15 @@ class test_runner | |||
| catch (fizzy::parser_error const& ex) | |||
| { | |||
| if (type == "assert_malformed") | |||
| pass(); | |||
| pass(ex.what()); | |||
There was a problem hiding this comment.
It would be better to also include the expected error kind, e.g.
Suggested change
| pass(ex.what()); | |
| pass("malformed: " + ex.what()); |
There was a problem hiding this comment.
Each line already includes the kind of assertion it tests:
Line 29: assert_invalid PASSED invalid index of an exported function
Line 6: assert_malformed PASSED invalid wasm module prefix
There was a problem hiding this comment.
Ah ok. This is not visible in the added CTest test.
chfast
requested changes
Dec 11, 2020
| set_tests_properties( | ||
| fizzy/smoketests/spectests/showpassed-error-message | ||
| PROPERTIES | ||
| PASS_REGULAR_EXPRESSION "PASSED invalid wasm module prefix" |
There was a problem hiding this comment.
Suggested change
| PASS_REGULAR_EXPRESSION "PASSED invalid wasm module prefix" | |
| PASS_REGULAR_EXPRESSION "assert_invalid PASSED invalid wasm module prefix" |
gumb0
force-pushed
the
spectest-pass-error
branch
from
3dd9269
to
45a0c29
Compare
chfast
approved these changes
Dec 11, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be helpful, when you'd like to check whether the invalid case fails for the right reason.
(It is displayed only with
--show-passedoption)