capi: Cloning a module #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #674 +/- ##
==========================================
- Coverage 99.29% 99.27% -0.02%
==========================================
Files 71 71
Lines 9821 9853 +32
==========================================
+ Hits 9752 9782 +30
- Misses 69 71 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
axic
reviewed
Dec 15, 2020
axic
reviewed
Dec 15, 2020
axic
reviewed
Dec 15, 2020
gumb0
force-pushed
the
capi-clone-module
branch
from
afa78e8
to
a73ef7a
Compare
axic
reviewed
Dec 15, 2020
gumb0
force-pushed
the
capi-clone-module
branch
from
a73ef7a
to
b21c1f6
Compare
gumb0
force-pushed
the
capi-clone-module
branch
from
b21c1f6
to
7d5b753
Compare
axic
reviewed
Dec 21, 2020
|
|
||
| const auto* module2 = fizzy_clone_module(module1); | ||
| EXPECT_NE(module2, nullptr); | ||
| EXPECT_NE(module1, module2); |
There was a problem hiding this comment.
I guess we can't do a "deep equal" without some new API 😉
axic
approved these changes
Dec 21, 2020
chfast
approved these changes
Dec 21, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.