capi: Export inspection functions #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #686 +/- ##
=======================================
Coverage 99.30% 99.31%
=======================================
Files 72 72
Lines 10420 10470 +50
=======================================
+ Hits 10348 10398 +50
Misses 72 72
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gumb0
force-pushed
the
capi-exports-inspection
branch
3 times, most recently
from
0d84006
to
2db892b
Compare
axic
reviewed
Jan 26, 2021
| } FizzyExternalKind; | ||
|
|
||
| /// Export description. | ||
| typedef struct FizzyExportDescription |
There was a problem hiding this comment.
Same comment as with FizzyImportDescription: #683 (comment). Please add a remark about the lifetime of name.
axic
reviewed
Jan 26, 2021
include/fizzy/fizzy.h
Outdated
| @@ -133,6 +133,27 @@ typedef struct FizzyExternalGlobal | |||
| FizzyGlobalType type; | |||
| } FizzyExternalGlobal; | |||
|
|
|||
| /// External kind. | |||
| typedef enum FizzyExternalKind | |||
There was a problem hiding this comment.
Oh, this is in conflict with #683, so need to merge one first then rebase.
axic
reviewed
Jan 26, 2021
include/fizzy/fizzy.h
Outdated
| /// @return Number of exports in the module. | ||
| uint32_t fizzy_get_export_count(const FizzyModule* module); | ||
|
|
||
| /// Get the import description defined in the module. |
axic
approved these changes
Jan 26, 2021
gumb0
commented
Jan 26, 2021
gumb0
force-pushed
the
capi-exports-inspection
branch
from
2db892b
to
072229e
Compare
axic
reviewed
Jan 26, 2021
include/fizzy/fizzy.h
Outdated
| /// Export kind. | ||
| FizzyExternalKind kind; | ||
| /// Index of exported function or table or memory or global. | ||
| /// #kind determines what is this index of. |
There was a problem hiding this comment.
Suggested change
| /// #kind determines what is this index of. | |
| /// #kind determines what is this the index of. |
gumb0
force-pushed
the
capi-exports-inspection
branch
from
072229e
to
a83cf57
Compare
axic
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.