test: Drop as_uint32() #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #691 +/- ##
==========================================
- Coverage 99.30% 99.30% -0.01%
==========================================
Files 72 72
Lines 10304 10300 -4
==========================================
- Hits 10232 10228 -4
Misses 72 72
Flags with carried forward coverage won't be shown. Click here to find out more.
|
axic
reviewed
Jan 19, 2021
test/unittests/execute_call_test.cpp
Outdated
| @@ -433,12 +433,10 @@ TEST(execute_call, imported_functions_call_indirect) | |||
| ASSERT_EQ(module->codesec.size(), 2); | |||
|
|
|||
| constexpr auto sqr = [](Instance&, const Value* args, int) { | |||
| const auto x = as_uint32(args[0]); | |||
| return Value{uint64_t{x} * uint64_t{x}}; | |||
| return Value{uint64_t{(args[0].i32)} * uint64_t{(args[0].i32)}}; | |||
There was a problem hiding this comment.
Why are the extra parentheses needed?
There was a problem hiding this comment.
automatic refactoring... There is "inline variable" command in CLion which placed x in both places where it was used.
axic
approved these changes
Jan 19, 2021
chfast
force-pushed
the
value_i32
branch
2 times, most recently
from
8957aab
to
0fd8f0d
Compare
chfast
force-pushed
the
drop_as_uint32
branch
from
da1d364
to
a2875da
Compare
chfast
force-pushed
the
drop_as_uint32
branch
from
a2875da
to
652b7dd
Compare
axic
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #517.