capi: Random minor simplifications #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
Jan 27, 2021
| imported_func.module = | ||
| c_imported_func.module ? std::string{c_imported_func.module} : std::string{}; | ||
| imported_func.name = c_imported_func.name ? std::string{c_imported_func.name} : std::string{}; | ||
| imported_func.module = c_imported_func.module; |
There was a problem hiding this comment.
https://stackoverflow.com/a/10771938
But we require module and name to be non-null, right?
There was a problem hiding this comment.
Right, that's why it was unnecessary check.
Codecov Report
@@ Coverage Diff @@
## master #699 +/- ##
==========================================
- Coverage 99.31% 99.31% -0.01%
==========================================
Files 72 72
Lines 10542 10541 -1
==========================================
- Hits 10470 10469 -1
Misses 72 72
Flags with carried forward coverage won't be shown. Click here to find out more.
|
axic
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One commit from #660 and one commit from #694