-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust: use i32 type in Value #702
Conversation
} | ||
pub fn as_u32(&self) -> u32 { | ||
unsafe { self.i64 as u32 } | ||
unsafe { self.i32 } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The confusing fact is that even though it is called i32
, the type is u32
in the bindgen translated fizzy.h.
Codecov Report
@@ Coverage Diff @@
## master #702 +/- ##
=======================================
Coverage 99.31% 99.31%
=======================================
Files 72 72
Lines 10628 10628
=======================================
Hits 10555 10555
Misses 73 73
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like no unit tests use i64
now (neither floating point types)
Consider adding tests for Value
conversions.
Sure, but what test exactly? Neither |
This is the kind of test we could have (this passes, at least on my CPU/FPU):
|
Depends on #517.