test: Unit test for CResult matcher #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
force-pushed
the
cresult-test
branch
2 times, most recently
from
ffe9944
to
fe60cde
Compare
Codecov Report
@@ Coverage Diff @@
## master #712 +/- ##
==========================================
+ Coverage 99.32% 99.33% +0.01%
==========================================
Files 73 73
Lines 10885 10917 +32
==========================================
+ Hits 10811 10844 +33
+ Misses 74 73 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
axic
reviewed
Feb 2, 2021
test/unittests/test_utils_test.cpp
Outdated
|
|
||
| EXPECT_THAT(trap, Not(CResult(0_u32))); | ||
| EXPECT_THAT(result_void, Not(CResult(0_u32))); | ||
| FizzyValue value_i32{0}; |
There was a problem hiding this comment.
Would we be better not using 0 but actual values in these tests?
There was a problem hiding this comment.
Not sure, but maybe we would, I'll change it.
chfast
approved these changes
Feb 3, 2021
axic
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves coverage in
asserts.hpp