rust: support cloning Modules #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #719 +/- ##
=======================================
Coverage 99.34% 99.34%
=======================================
Files 73 73
Lines 11125 11142 +17
=======================================
+ Hits 11052 11069 +17
Misses 73 73
Flags with carried forward coverage won't be shown. Click here to find out more.
|
axic
commented
Feb 4, 2021
| @@ -20,10 +20,21 @@ pub struct Module(*const sys::FizzyModule); | |||
|
|
|||
| impl Drop for Module { | |||
| fn drop(&mut self) { | |||
| debug_assert!(!self.0.is_null()); | |||
There was a problem hiding this comment.
Changed these to debug_assert and added it to all relevant places. A failure of this would mean a programming error in our code, and not user code. Hence debug_assert, i.e. it will be caught by our tests assuming we have high enough coverage.
axic
commented
Feb 4, 2021
| fn clone(&self) -> Self { | ||
| debug_assert!(!self.0.is_null()); | ||
| let ptr = unsafe { sys::fizzy_clone_module(self.0) }; | ||
| // TODO: this can be zero in case of memory allocation error, should this be gracefully handled? |
There was a problem hiding this comment.
That being said the clone trait does not support optionality.
chfast
approved these changes
Feb 4, 2021
gumb0
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.