Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: add simple CostNonNull wrapper based on std::ptr::NonNull #720

Merged
merged 1 commit into from
May 23, 2022

Conversation

axic
Copy link
Member

@axic axic commented Feb 4, 2021

No description provided.

@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #720 (7694ed6) into master (7b700be) will decrease coverage by 0.02%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master     #720      +/-   ##
==========================================
- Coverage   99.12%   99.10%   -0.03%     
==========================================
  Files          85       86       +1     
  Lines       13010    13017       +7     
==========================================
+ Hits        12896    12900       +4     
- Misses        114      117       +3     
Flag Coverage Δ
rust 99.60% <80.00%> (-0.30%) ⬇️
spectests 89.98% <ø> (ø)
unittests 98.94% <ø> (ø)
unittests-32 99.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bindings/rust/src/constnonnull.rs 70.00% <70.00%> (ø)
bindings/rust/src/lib.rs 99.90% <100.00%> (-0.01%) ⬇️

@axic axic force-pushed the rust-constnull branch 2 times, most recently from a49c6d9 to bf1c1df Compare February 12, 2021 17:00
@axic axic marked this pull request as ready for review May 21, 2022 13:14
@axic axic requested review from chfast and gumb0 May 21, 2022 13:14
@axic
Copy link
Member Author

axic commented May 22, 2022

@chfast @gumb0 please review

Copy link
Collaborator

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is little smelly to me to introduce new vocabulary types in the library. But I'm leaving Rust API design to others.

@axic axic merged commit c341e3a into master May 23, 2022
@axic axic deleted the rust-constnull branch May 23, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants