test: Empty memory support #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #732 +/- ##
=======================================
Coverage 99.34% 99.34%
=======================================
Files 73 73
Lines 11142 11164 +22
=======================================
+ Hits 11069 11091 +22
Misses 73 73
Flags with carried forward coverage won't be shown. Click here to find out more.
|
axic
reviewed
Feb 9, 2021
| /* wat2wasm | ||
| (memory 0) | ||
| */ | ||
| const auto wasm_memory_empty = from_hex("0061736d010000000503010000"); |
There was a problem hiding this comment.
Why is this duplicated in two test cases?
There was a problem hiding this comment.
One test here checks module inspection function fizzy_module_has_memory
The test below checks instance memory access functions.
axic
approved these changes
Feb 9, 2021
chfast
approved these changes
Feb 10, 2021
include/fizzy/fizzy.h
Outdated
| @@ -450,6 +450,8 @@ const FizzyModule* fizzy_get_instance_module(FizzyInstance* instance); | |||
| /// @return Pointer to memory data or NULL in case instance doesn't have any memory. | |||
| /// | |||
| /// @note Function returns pointer to memory regardless of whether memory is exported or not. | |||
| /// @note For instances of the modules defined with memory of size 0 the returned pointers is not | |||
There was a problem hiding this comment.
Suggested change
| /// @note For instances of the modules defined with memory of size 0 the returned pointers is not | |
| /// @note For instances of the modules defined with memory of size 0 the returned pointers are not |
gumb0
force-pushed
the
empty-memory-test
branch
from
f1d790b
to
a1bdb83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.