Upgrade Hunter to get newer nlohmann_json #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #736 +/- ##
=======================================
Coverage 99.35% 99.35%
=======================================
Files 73 73
Lines 11388 11388
=======================================
Hits 11315 11315
Misses 73 73
Flags with carried forward coverage won't be shown. Click here to find out more. |
chfast
changed the title
chfast
reviewed
Feb 16, 2021
| @@ -2,6 +2,4 @@ | |||
| hunter_config( | |||
| benchmark | |||
| VERSION 1.5.0 | |||
| URL https://github.com/google/benchmark/archive/v1.5.0.tar.gz | |||
There was a problem hiding this comment.
Why is this removed? If we get benchmark 1.5.0 by default you can remove all of it.
There was a problem hiding this comment.
Yes, it's default.
Should I leave this file empty? It complains if I delete it:
-- Build type: Debug
[hunter ** FATAL ERROR **] Config not found: /home/andrei/dev/fizzy/cmake/Hunter/config.cmake
[hunter ** FATAL ERROR **] [Directory:/home/andrei/dev/fizzy/test]
------------------------------ ERROR -----------------------------
https://hunter.readthedocs.io/en/latest/reference/errors/error.incorrect.input.data.html
------------------------------------------------------------------
CMake Error at /home/andrei/.hunter/_Base/Download/Hunter/0.23.294/0dd1ee8/Unpacked/cmake/modules/hunter_error_page.cmake:12 (message):
Call Stack (most recent call first):
/home/andrei/.hunter/_Base/Download/Hunter/0.23.294/0dd1ee8/Unpacked/cmake/modules/hunter_fatal_error.cmake:20 (hunter_error_page)
/home/andrei/.hunter/_Base/Download/Hunter/0.23.294/0dd1ee8/Unpacked/cmake/modules/hunter_user_error.cmake:7 (hunter_fatal_error)
/home/andrei/.hunter/_Base/Download/Hunter/0.23.294/0dd1ee8/Unpacked/cmake/modules/hunter_set_config_location.cmake:50 (hunter_user_error)
/home/andrei/.hunter/_Base/Download/Hunter/0.23.294/0dd1ee8/Unpacked/cmake/modules/hunter_apply_gate_settings.cmake:85 (hunter_set_config_location)
/home/andrei/.hunter/_Base/Download/Hunter/0.23.294/0dd1ee8/Unpacked/cmake/modules/hunter_finalize.cmake:73 (hunter_apply_gate_settings)
/home/andrei/.hunter/_Base/Download/Hunter/0.23.294/0dd1ee8/Unpacked/cmake/modules/hunter_add_package.cmake:23 (hunter_finalize)
test/CMakeLists.txt:16 (hunter_add_package)
-- Configuring incomplete, errors occurred!
See also "/home/andrei/dev/fizzy/build/CMakeFiles/CMakeOutput.log".
See also "/home/andrei/dev/fizzy/build/CMakeFiles/CMakeError.log".
There was a problem hiding this comment.
You can remove the file if you also remove the LOCAL option from HunterGate().
gumb0
force-pushed
the
update-huntergate
branch
from
dfaf882
to
6703fd3
Compare
gumb0
force-pushed
the
update-huntergate
branch
from
6703fd3
to
b37a7d5
Compare
axic
approved these changes
Feb 16, 2021
chfast
approved these changes
Feb 16, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for #716
Older version of nlohmann_json has some compilation errors when
<any>is included, see #716 (comment) for links.