noexcept execution #738
Merged
noexcept execution #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #738 +/- ##
=======================================
Coverage 99.25% 99.25%
=======================================
Files 76 76
Lines 11571 11571
=======================================
Hits 11485 11485
Misses 86 86
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
GCC 10.2 with LTO, #716 vs noexcept master vs noexcept |
gumb0
force-pushed
the
execute-function-noexcept
branch
from
2c0a471
to
b035078
Compare
gumb0
force-pushed
the
execute-function-noexcept2
branch
from
94791c7
to
858cb04
Compare
|
Clang11, master vs noexcept: |
|
Clang11 #716 vs noexcept master vs noexcept: |
gumb0
force-pushed
the
execute-function-noexcept
branch
2 times, most recently
from
b8942e9
to
7e78d7b
Compare
gumb0
force-pushed
the
execute-function-noexcept2
branch
from
858cb04
to
3062b4d
Compare
gumb0
force-pushed
the
execute-function-noexcept
branch
from
7e78d7b
to
fb256d1
Compare
gumb0
force-pushed
the
execute-function-noexcept2
branch
from
3062b4d
to
b5ad31e
Compare
gumb0
force-pushed
the
execute-function-noexcept
branch
from
fb256d1
to
cff1342
Compare
gumb0
force-pushed
the
execute-function-noexcept2
branch
2 times, most recently
from
8b8c66c
to
d306b86
Compare
gumb0
force-pushed
the
execute-function-noexcept
branch
from
cff1342
to
ce0536c
Compare
gumb0
force-pushed
the
execute-function-noexcept2
branch
from
d306b86
to
ffda4ba
Compare
gumb0
force-pushed
the
execute-function-noexcept
branch
from
ce0536c
to
1996489
Compare
gumb0
force-pushed
the
execute-function-noexcept2
branch
from
ffda4ba
to
61d30e2
Compare
axic
reviewed
Mar 10, 2021
| int) -> ExecutionResult { | ||
| return std::any_cast<Value>(host_context); | ||
| int) noexcept -> ExecutionResult { | ||
| return *std::any_cast<Value>(&host_context); |
There was a problem hiding this comment.
Why is this needed for noexcept and why wasn't this done in #716?
There was a problem hiding this comment.
any_cast taking a reference returns error by throwing bad_cast exception.
Here it's changed to any_cast taking a pointer, which returns nullptr in case of error.
There was a problem hiding this comment.
Ah okay. Though this could have been done as reference in the first place in #716.
gumb0
force-pushed
the
execute-function-noexcept
branch
3 times, most recently
from
16e12bc
to
0ad804f
Compare
gumb0
force-pushed
the
execute-function-noexcept2
branch
from
61d30e2
to
f381ae7
Compare
gumb0
force-pushed
the
execute-function-noexcept2
branch
from
f381ae7
to
4aaccab
Compare
chfast
approved these changes
Mar 11, 2021
gumb0
force-pushed
the
execute-function-noexcept2
branch
from
4aaccab
to
3088493
Compare
gumb0
force-pushed
the
execute-function-noexcept2
branch
from
3088493
to
cc6dced
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #716