test: Refactor translate_signature in wasm_engine #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
reviewed
Feb 25, 2021
gumb0
approved these changes
Feb 25, 2021
Codecov Report
@@ Coverage Diff @@
## master #741 +/- ##
=======================================
Coverage 99.26% 99.26%
=======================================
Files 73 74 +1
Lines 11413 11414 +1
=======================================
+ Hits 11329 11330 +1
Misses 84 84
Flags with carried forward coverage won't be shown. Click here to find out more.
|
axic
force-pushed
the
wasm-engine
branch
2 times, most recently
from
99230c8
to
5f30ebd
Compare
chfast
approved these changes
Feb 25, 2021
gumb0
approved these changes
Feb 26, 2021
This replaces the implementation in fizzy_engine with a template.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #739 (comment) .