rust: return string as an error #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
commented
Feb 26, 2021
| ); | ||
| assert_eq!( | ||
| instance.checked_memory_slice(65535, 1).err().unwrap(), | ||
| "no memory is available" |
There was a problem hiding this comment.
I am not sold we need to check in every case, but at least it is clear.
Codecov Report
@@ Coverage Diff @@
## master #743 +/- ##
=======================================
Coverage 99.26% 99.26%
=======================================
Files 74 74
Lines 11414 11442 +28
=======================================
+ Hits 11330 11358 +28
Misses 84 84
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gumb0
approved these changes
Feb 26, 2021
axic
force-pushed
the
rust-error-string
branch
from
dfd176f
to
f515f7f
Compare
chfast
approved these changes
Feb 26, 2021
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the string version of #677.