Construct Value only from uint32_t/uint64_t #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #746 +/- ##
==========================================
- Coverage 99.26% 99.26% -0.01%
==========================================
Files 74 74
Lines 11442 11439 -3
==========================================
- Hits 11358 11355 -3
Misses 84 84
Flags with carried forward coverage won't be shown. Click here to find out more.
|
axic
approved these changes
Mar 2, 2021
gumb0
reviewed
Mar 2, 2021
lib/fizzy/value.hpp
Outdated
| @@ -26,11 +26,10 @@ union Value | |||
| /// We need to support {signed,unsigned} x {32,64} integers. However, due to uint64_t being | |||
axic
approved these changes
Mar 3, 2021
gumb0
reviewed
Mar 3, 2021
lib/fizzy/value.hpp
Outdated
Comment on lines
27
to
28
| /// Some issues are expected when uint64_t is not unsigned long. | ||
| /// Then Value cannot be constructed out of unsigned long literals. |
There was a problem hiding this comment.
"some issues" sounds a bit confusing to me, maybe this:
Suggested change
| /// Some issues are expected when uint64_t is not unsigned long. | |
| /// Then Value cannot be constructed out of unsigned long literals. | |
| /// On the platforms where uint64_t is not unsigned long, it is expected that | |
| /// Value cannot be constructed out of unsigned long literals. |
gumb0
approved these changes
Mar 3, 2021
This disables Value constructors for unsigned integers for types other than uint32_t/uint64_t. This requires users to use these types. This can cause portability issues on macOS/Linux if type like unsigned long is used. This also helps in 32-bit port.
gumb0
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables Value constructors for unsigned integers for types other
than uint32_t/uint64_t. This requires users to use these types.
This can cause portability issues on macOS/Linux if type like
unsigned long is used. This also helps in 32-bit port.