test: Do not bump depth in host functions #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #761 +/- ##
=======================================
Coverage 99.26% 99.26%
=======================================
Files 77 77
Lines 11718 11718
=======================================
Hits 11632 11632
Misses 86 86
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chfast
force-pushed
the
depth_tests
branch
5 times, most recently
from
1e28bba
to
913da5e
Compare
chfast
force-pushed
the
depth_improvements_v2
branch
from
dff0752
to
06eb623
Compare
axic
approved these changes
Mar 18, 2021
This removes the test cases where host functions dump the wasm call depth. This is still possible (two cases doing that remain) but not recommended implementation.
chfast
force-pushed
the
depth_improvements_v2
branch
from
06eb623
to
00c1ae9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #757.
This removes the test cases where host functions dump the wasm call
depth. This is still possible (two cases doing that remain) but not
recommended implementation.
The remaining two cases should be cleaned up and moved to
execute_call_depth_test.