capi: Reporting error code and message #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
commented
Mar 25, 2021
gumb0
commented
Mar 25, 2021
gumb0
commented
Mar 25, 2021
Codecov Report
@@ Coverage Diff @@
## master #772 +/- ##
==========================================
- Coverage 99.25% 99.23% -0.03%
==========================================
Files 77 77
Lines 11744 11886 +142
==========================================
+ Hits 11657 11795 +138
- Misses 87 91 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gumb0
force-pushed
the
rich-error-reporting-simple
branch
9 times, most recently
from
3ee2e20
to
d1f3437
Compare
axic
reviewed
Mar 29, 2021
axic
reviewed
Mar 29, 2021
axic
reviewed
Mar 29, 2021
gumb0
force-pushed
the
rich-error-reporting-simple
branch
from
d1f3437
to
b43b605
Compare
axic
reviewed
Mar 29, 2021
gumb0
force-pushed
the
rich-error-reporting-simple
branch
from
cf4e569
to
8f496ce
Compare
gumb0
force-pushed
the
rich-error-reporting-simple
branch
from
8f496ce
to
b69523d
Compare
axic
reviewed
Mar 30, 2021
gumb0
force-pushed
the
rich-error-reporting-simple
branch
2 times, most recently
from
c4d8a01
to
c5ffc19
Compare
axic
approved these changes
Mar 30, 2021
chfast
reviewed
Mar 31, 2021
gumb0
force-pushed
the
rich-error-reporting-simple
branch
2 times, most recently
from
528b0dd
to
4a0e275
Compare
chfast
requested changes
Mar 31, 2021
gumb0
force-pushed
the
rich-error-reporting-simple
branch
from
4a0e275
to
a62544f
Compare
chfast
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simpler alternative to #764, not introducing any error codes on C++ side for now.