test: Fix f32.demote_f64 nan test cases #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #793 +/- ##
=======================================
Coverage 99.23% 99.23%
=======================================
Files 79 79
Lines 12394 12394
=======================================
Hits 12299 12299
Misses 95 95
Flags with carried forward coverage won't be shown. Click here to find out more.
|
axic
reviewed
May 5, 2021
| @@ -173,8 +173,8 @@ TEST(execute_floating_point_conversion, f32_demote_f64) | |||
| {0x1.fffffcp0, 0x1.fffffcp0f}, // exact (even) | |||
|
|
|||
| // The canonical NaN must result in canonical NaN (only the top bit of payload set). | |||
| {FP32::nan(FP32::canon), FP64::nan(FP64::canon)}, | |||
| {-FP32::nan(FP32::canon), -FP64::nan(FP64::canon)}, | |||
| {FP64::nan(FP64::canon), FP32::nan(FP32::canon)}, | |||
There was a problem hiding this comment.
Ah, the signature of the struct is double, float.
axic
approved these changes
May 5, 2021
gumb0
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.