Fix handling memory of max size on 32-bit systems: check for size_t overflow #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## only-memory-size-helper #808 +/- ##
===========================================================
- Coverage 99.02% 99.00% -0.03%
===========================================================
Files 81 81
Lines 12825 12845 +20
===========================================================
+ Hits 12700 12717 +17
- Misses 125 128 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gumb0
changed the title
gumb0
changed the title
gumb0
force-pushed
the
only-memory-size-helper
branch
from
267ddc0
to
20cb1a0
Compare
gumb0
force-pushed
the
max-memory-32bit
branch
5 times, most recently
from
bedb050
to
85cf7a8
Compare
gumb0
commented
Jan 11, 2022
lib/fizzy/limits.hpp
Outdated
| typename = | ||
| typename std::enable_if_t<std::is_integral_v<TypeFrom> && std::is_integral_v<TypeTo> && | ||
| sizeof(TypeFrom) >= sizeof(TypeTo)>> | ||
| inline constexpr bool can_narrow_cast(TypeFrom value) noexcept |
There was a problem hiding this comment.
This is not about limits anymore, move to a new header?
gumb0
force-pushed
the
max-memory-32bit
branch
from
85cf7a8
to
7fb9138
Compare
chfast
reviewed
Jan 11, 2022
lib/fizzy/execute.cpp
Outdated
| return static_cast<uint32_t>(-1); | ||
| #pragma clang diagnostic pop | ||
| } | ||
| if (!can_narrow_cast<size_t>(new_bytes)) |
There was a problem hiding this comment.
The GSL introduced narrow_cast and narrow. The narrow throws exception if conversion changes value. The narrow_cast is just an alias for static_cast so it always succeeds. So probably better name would be can_narrow or can_safely_narrow.
gumb0
force-pushed
the
max-memory-32bit
branch
3 times, most recently
from
9bfd43e
to
e9877d8
Compare
chfast
approved these changes
Jan 11, 2022
It may fail only on 32-bit systems.
gumb0
force-pushed
the
max-memory-32bit
branch
from
e9877d8
to
c5b89ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #807