capi: Add static assertions for FizzyValueType* vs. fizzy:ValType::* #821
Conversation
Codecov Report
@@ Coverage Diff @@
## master #821 +/- ##
=======================================
Coverage 99.28% 99.28%
=======================================
Files 86 86
Lines 13221 13221
=======================================
Hits 13126 13126
Misses 95 95
Flags with carried forward coverage won't be shown. Click here to find out more. |
| { | ||
| A = 0xff | ||
| }; | ||
| EXPECT_EQ(to_underlying(A::A), 0xff); |
There was a problem hiding this comment.
Add `static_assert(std::is_same_v<decltype(to_underlying(A::A)), int>);
There was a problem hiding this comment.
Specs said it is at least int. So this may fail on some platforms?
There was a problem hiding this comment.
Also did you know that the C enum (decltype(C::A)) defaults to unsigned int?
There was a problem hiding this comment.
It will be bigger than int only if some values don't fit int
There was a problem hiding this comment.
For scoped enumerations (enum class) the implicit underlying type is int. In case value do not fit, this is compile error. https://godbolt.org/z/1x8ffaadW.
There was a problem hiding this comment.
I feel like we are adding C++ compiler compliance tests at this point 😅
There was a problem hiding this comment.
I just wanted to know if this returns the same type as in the enum declaration. If you want to be explicit, you can define it as enum class A : int.
| { | ||
| A = 0xff | ||
| }; | ||
| static_assert(std::is_same_v<decltype(to_underlying(C::A)), unsigned int>); |
There was a problem hiding this comment.
No. This can be any integer type.
axic
force-pushed
the
capi-valtype
branch
2 times, most recently
from
625c375
to
a229fe1
Compare
| static_assert(FizzyValueTypeF64 == fizzy::to_underlying(fizzy::ValType::f64)); | ||
| static_assert(FizzyValueTypeVoid == 0); | ||
| static_assert(std::is_same_v<decltype(fizzy::to_underlying(fizzy::ValType::i32)), | ||
| std::remove_const<decltype(FizzyValueTypeI32)>::type>); |
| { | ||
| A = 0xff | ||
| }; | ||
| static_assert(std::is_same_v<decltype(to_underlying(C::A)), unsigned int>); |
There was a problem hiding this comment.
No. This can be any integer type.
| { | ||
| A = 0xff | ||
| }; | ||
| EXPECT_EQ(to_underlying(A::A), 0xff); |
There was a problem hiding this comment.
I just wanted to know if this returns the same type as in the enum declaration. If you want to be explicit, you can define it as enum class A : int.
The others are explicit, intentionally left in the implicit one. |
No description provided.