Made CI checks during telemetry a bit more thorough. #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infomiho
reviewed
Nov 29, 2023
| unwords . filter (not . null) | ||
| <$> sequence | ||
| [ fromMaybe "" <$> ENV.lookupEnv "WASP_TELEMETRY_CONTEXT", | ||
| checkIfOnCi <&> \case True -> "CI"; False -> "" | ||
| checkIfOnCi <&> \case True -> "CI"; False -> "", | ||
| -- NOTE(martin): We are not 100% sure how correctly does `hIsTerminalDevice` detect |
There was a problem hiding this comment.
@Martinsos can this call fail for what ever reason? Do we need exception handling or smth here
There was a problem hiding this comment.
Good point -> so I didn't think this one is particularly likely to throw an error (but every IO operation can throw an error!), so I haven't taken special measures here.
We do have one big catch already for telemetry, so any fail in it can't crash the CLI but will just not send telemetry.
That said, this function is a bit of a mystery to us, and it would be a shame if it started failing our telemetry silently, so better to be safe than sorry I think, so now prompted by your comment I added an additional catch to it that will interpret any error as "True".
infomiho
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.