Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs update for Hacktoberfest #731
Docs update for Hacktoberfest #731
Changes from 2 commits
4391e0b
fc59fb3
c0fd547
e628bf0
9a8abd5
aec4f67
f085d7c
7a18d33
92b5789
e81565d
790253a
4fe91ab
b57c449
6412f8d
2b7d3b9
0ff4670
0069aa5
8dc3a22
5a602b5
65ccd5b
b0e9096
dc0ce91
a2d871e
5f51bf0
4afd105
4281672
7a1c8dc
e8fcc19
fa718cd
9c3004c
6e86157
ac99892
9421bc7
e966507
ffb7f38
c407b30
7ff5568
ce1fce9
cde6722
7cfe6b8
4db561a
9b979b2
11ba4fb
7cc0315
997813e
26947fa
970b6d3
4505b5d
7487586
e69d3fd
9c2edd0
b5ac7fb
2f4c1d0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want people to merge their examples into our main repo?
Right now, examples we have are examples that we decided to put effort into maintaining and keeping up to date. If people added a number of their own examples, it would grow to an amount we can't support and maintain. Maybe we should rather encourage them to improve our example apps, and if they wish to show case their own example apps, they can add it to some kind of list that we could have somewhere -> I saw many projects having this, a list of projects using them, somewhere at the bottom of the README usually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea was to encourage people to build something with Wasp in the first place. And nothing can be more encouraging than being featured in the docs section of the tool you're using. I'd like to leave the possibility for people to create example apps. And we can decide later in what format it will be.
If the app is great -- it can be made into a tutorial. If it's not great but good enough -- we can ask a developer to commit to maintaining it. And if the dev won't be doing that -- we can remove it from examples list or figure out, whether someone else from the community would like to update it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am for it, I just wouldn't promise to make it part of our main repo (wasp-lang/wasp) because we already have too much work with maintaining the existing ones. So instead, best if they create them in their own repo -> but we can certainly feature them in our docs!