-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docusaurus and use node 18 #797
Conversation
}, | ||
gtag: { | ||
trackingID: 'G-3ZEDH3BVGE', | ||
anonymizeIP: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was already down below, and I had to remove it to compile. Ref: facebook/docusaurus#5832
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm honestly I don't remember seeing this before, sounds like something for google analytics? But if we have it in some other place then probably it's ok
"react": "^17.0.1", | ||
"react-dom": "^17.0.1", | ||
"react-modal": "^3.14.3", | ||
"url-loader": "^4.1.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does anyone know why we had url-loader
and file-loader
in here? They were causing problems, so I removed them. I did not see any references to them in code. They were also not in the brand new docusaurus test project I setup. Maybe just old cruft?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember it actually, probably some leftover. Ok to remove imo.
return ( | ||
<div className='code-with-header'> | ||
<div className="code-header">{ title }</div> | ||
|
||
<CodeBlock className={language} metastring={metastring}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The syntax for this changed, and I removed metastring
since we did not use it, and it was mentioned to avoid: https://docusaurus.io/docs/next/markdown-features/code-blocks#usage-in-jsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! thanks a lot for updating this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Awesome that you updated docusaurus, they have some cool new features I wanted to use :).
}, | ||
gtag: { | ||
trackingID: 'G-3ZEDH3BVGE', | ||
anonymizeIP: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm honestly I don't remember seeing this before, sounds like something for google analytics? But if we have it in some other place then probably it's ok
"react": "^17.0.1", | ||
"react-dom": "^17.0.1", | ||
"react-modal": "^3.14.3", | ||
"url-loader": "^4.1.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember it actually, probably some leftover. Ok to remove imo.
return ( | ||
<div className='code-with-header'> | ||
<div className="code-header">{ title }</div> | ||
|
||
<CodeBlock className={language} metastring={metastring}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! thanks a lot for updating this.
3171b89
to
2072798
Compare
* Added 'How Wasp got to 1k stars on gh' blog post. * Docs update for Hacktoberfest (#731) * Initial docs update for Hacktoberfest * Contributing.md update * Update "Before you begin" section * Update web/docs/tutorials/dev-excuses-app/creating-the-project.md Co-authored-by: Martin Šošić <Martinsos@users.noreply.github.com> * Update web/docs/tutorials/dev-excuses-app/updating-main-page-js-file.md Co-authored-by: Martin Šošić <Martinsos@users.noreply.github.com> * Update CONTRIBUTING.md Co-authored-by: Martin Šošić <Martinsos@users.noreply.github.com> * Update web/docs/tutorials/dev-excuses-app/modifying-main-wasp-file.md Co-authored-by: Martin Šošić <Martinsos@users.noreply.github.com> * Update the section names * Update CONTRIBUTING.md Co-authored-by: Matija Sosic <matija.sosic@gmail.com> * Update web/docs/tutorials/dev-excuses-app/updating-main-page-js-file.md Co-authored-by: Matija Sosic <matija.sosic@gmail.com> * Update web/docs/contributing.md Co-authored-by: Matija Sosic <matija.sosic@gmail.com> * Update web/docs/contributing.md Co-authored-by: Matija Sosic <matija.sosic@gmail.com> * Update web/docs/contributing.md Co-authored-by: Matija Sosic <matija.sosic@gmail.com> * Add Discord component and some minor fixes * Add unclear notice * Update web/docs/pick-a-tutorial.md Co-authored-by: Matija Sosic <matija.sosic@gmail.com> * Update web/docs/tutorials/dev-excuses-app.md Co-authored-by: Matija Sosic <matija.sosic@gmail.com> * Update web/docs/tutorials/dev-excuses-app.md Co-authored-by: Matija Sosic <matija.sosic@gmail.com> * Update web/docs/tutorials/dev-excuses-app.md Co-authored-by: Matija Sosic <matija.sosic@gmail.com> * Update CONTRIBUTING.md Co-authored-by: Matija Sosic <matija.sosic@gmail.com> * Update web/docs/tutorials/dev-excuses-app/modifying-main-wasp-file.md Co-authored-by: Matija Sosic <matija.sosic@gmail.com> * Update web/docs/getting-started.md Co-authored-by: Matija Sosic <matija.sosic@gmail.com> * Update web/docs/tutorials/dev-excuses-app/modifying-main-wasp-file.md Co-authored-by: Matija Sosic <matija.sosic@gmail.com> * Review updates * Update web/docs/tutorials/dev-excuses-app/modifying-main-wasp-file.md Co-authored-by: Matija Sosic <matija.sosic@gmail.com> * Update suggestion * Update web/docs/tutorials/dev-excuses-app/perform-migration-and-run.md Co-authored-by: Matija Sosic <matija.sosic@gmail.com> * Update web/docs/tutorials/dev-excuses-app/perform-migration-and-run.md Co-authored-by: Matija Sosic <matija.sosic@gmail.com> * Update * Update web/docs/tutorials/dev-excuses-app/updating-main-page-js-file.md Co-authored-by: Matija Sosic <matija.sosic@gmail.com> * Update CONTRIBUTING.md Co-authored-by: Matija Sosic <matija.sosic@gmail.com> * Remove lines * Update CONTRIBUTING.md Co-authored-by: Matija Sosic <matija.sosic@gmail.com> * Update CONTRIBUTING.md Co-authored-by: Matija Sosic <matija.sosic@gmail.com> * Update CONTRIBUTING.md Co-authored-by: Matija Sosic <matija.sosic@gmail.com> * Update getExcuse function * Update page naming convention * Remove Main.css * Update migration text * Update image * Update "Wasp's compiler is built with Haskell" * Add tutorials description * Update web/docs/pick-a-tutorial.md Co-authored-by: Matija Sosic <matija.sosic@gmail.com> * Update Discord link and tutorial ending * Update links Co-authored-by: mkhamrov <mkhamrov@redhat.com> Co-authored-by: Martin Šošić <Martinsos@users.noreply.github.com> Co-authored-by: Matija Sosic <matija.sosic@gmail.com> * Update to-do app tutorial links * Fixed a bit 'how to get started with haskell in 2022' blog post. * Small fix of 'Pick a Tutorial' doc page. (#737) * Linked Copilot post to its HN discussion. * Added Farnance showcase blog post. * Improved messaging about node version in getting started page in docs. * Added Beta announcement bar to the landing page and docs. * Update Docusaurus (#797) * Adds Fly.io to deployment guide (#803) Co-authored-by: Matija Sosic <matija.sosic@gmail.com> Co-authored-by: vincanger <70215737+vincanger@users.noreply.github.com> * Added Alpha Testing Program: post-mortem blog post. * Update features.md newUser snippets more explicit examples * add railway deployment (#818) * Added Hacktoberfest 2022 reflections blog post. * update Railway client deployment * add railway proxy warning * Update image thumbnail (#832) Co-authored-by: mkhamrov <mkhamrov@redhat.com> * Added Beta Launch Week announcement post. * small blog fix, updated thumbnail img. * Added Michael Curry (cursorial) use case blog post. * Added Erlis Kllogjri's Amicus use case blog post. * Fixed some grammar errors in use case posts. * first pass at both beta launch blog posts * minor edits * clean up Features, GoogleAuth, & Deploy docs (#820) * add railway deployment * clean up Features and GoogleAuth docs * Update web/docs/language/features.md Co-authored-by: Martin Šošić <Martinsos@users.noreply.github.com> Co-authored-by: Martin Sosic <sosic.martin@gmail.com> * Created new landing page for Beta. Co-authored-by: Matija Sosic <matija.sosic@gmail.com> Co-authored-by: Max Khamrovskyi <maksim36ua@gmail.com> Co-authored-by: mkhamrov <mkhamrov@redhat.com> Co-authored-by: Martin Šošić <Martinsos@users.noreply.github.com> Co-authored-by: Martin Sosic <sosic.martin@gmail.com> Co-authored-by: Shayne Czyzewski <523636+shayneczyzewski@users.noreply.github.com> Co-authored-by: vincanger <70215737+vincanger@users.noreply.github.com> Co-authored-by: shayneczyzewski <shayne.czyzewski@gmail.com>
Description
Updates docusaurus and other deps to latest versions, and now uses node 18.
Only minor changes visible (here is a before and after):
The main differences I notice are:
Type of change
Please select the option(s) that is more relevant.