add swagger + fix client errors/warnings

wassb92 · Aug 1, 2023 · f65997e · f65997e
1 parent 90c5fb9
commit f65997e
Show file tree

Hide file tree

Showing 7 changed files with 516 additions and 60 deletions.
diff --git a/client/public/index.html b/client/public/index.html
@@ -1,9 +1,9 @@
 <!DOCTYPE html>
 <html lang="en">
   <head>
-    <title>React App</title>
+    <title>NeoMovie - MyAllociné</title>
   </head>
   <body>
-    <div id="root"></div>  
+    <div id="root"></div>
   </body>
 </html>
diff --git a/client/public/manifest.json b/client/public/manifest.json
@@ -1,25 +0,0 @@
-{
-  "short_name": "React App",
-  "name": "Create React App Sample",
-  "icons": [
-    {
-      "src": "favicon.ico",
-      "sizes": "64x64 32x32 24x24 16x16",
-      "type": "image/x-icon"
-    },
-    {
-      "src": "logo192.png",
-      "type": "image/png",
-      "sizes": "192x192"
-    },
-    {
-      "src": "logo512.png",
-      "type": "image/png",
-      "sizes": "512x512"
-    }
-  ],
-  "start_url": ".",
-  "display": "standalone",
-  "theme_color": "#000000",
-  "background_color": "#ffffff"
-}

diff --git a/client/src/pages/private/Details.jsx b/client/src/pages/private/Details.jsx
@@ -134,7 +134,10 @@ const MovieModal = ({
           <div className="flex flex-row justify-center">
             {genres &&
               genres.map((genre) => (
-                <div className="bg-gray-800 text-white rounded-full px-3 mx-1 mb-4">
+                <div
+                  key={genre}
+                  className="bg-gray-800 text-white rounded-full px-3 mx-1 mb-4"
+                >
                   {genre}
                 </div>
               ))}
@@ -198,20 +201,28 @@ const Details = ({
   const [show, setShow] = useState(false);
   const [video, setVideo] = useState();
 
-  const fetchVideo = async () => {
-    const url = `${global.TMDB_API}/movie/${id}/videos?api_key=${global.API_KEY}&include_video_language=fr`;
+  useEffect(() => {
+    let isMounted = true;
 
-    try {
-      const res = await axios.get(url);
-      const data = await res.data.results;
-      setVideo(data);
-    } catch (e) {
-      console.log(e);
-    }
-  };
+    const fetchVideo = async () => {
+      const url = `${global.TMDB_API}/movie/${id}/videos?api_key=${global.API_KEY}&include_video_language=fr`;
+
+      try {
+        const res = await axios.get(url);
+        const data = await res.data.results;
+        if (isMounted) {
+          setVideo(data);
+        }
+      } catch (e) {
+        console.log(e);
+      }
+    };
 
-  useEffect(() => {
     fetchVideo();
+
+    return () => {
+      isMounted = false;
+    };
   }, []);
 
   const handleShow = () => setShow(true);

diff --git a/client/src/pages/private/Popular.jsx b/client/src/pages/private/Popular.jsx
@@ -142,7 +142,7 @@ const Filter = ({ onFilterChange, handleSearch }) => {
         >
           {languages.map((language) => (
             <option
-              key={language.id}
+              key={language.iso_639_1}
               value={language.iso_639_1}
               onChange={handleFilterChange}
             >
@@ -269,13 +269,11 @@ const Popular = () => {
             (movieReq) =>
               movieReq.id &&
               movieReq.poster_path && (
-                <>
-                  <Details
-                    key={movieReq.id}
-                    {...movieReq}
-                    genres={ConvertGenres(movieReq.genre_ids)}
-                  />
-                </>
+                <Details
+                  key={movieReq.id}
+                  {...movieReq}
+                  genres={ConvertGenres(movieReq.genre_ids)}
+                />
               )
           )}
         </div>

diff --git a/server/package-lock.json b/server/package-lock.json
diff --git a/server/package.json b/server/package.json
@@ -21,6 +21,7 @@
     "jsonwebtoken": "^9.0.1",
     "mongoose": "^7.4.1",
     "mongoose-unique-validator": "^4.0.0",
+    "swagger-autogen": "^2.23.5",
     "swagger-ui-express": "^5.0.0"
   },
   "devDependencies": {